Azure / logicapps

Azure Logic Apps labs, samples, and tools
MIT License
357 stars 299 forks source link

VS code extension pane view for "designer" and "Overview" is blank WSL2 #231

Closed Bandgren closed 3 years ago

Bandgren commented 3 years ago

Hi,

Im running into some issue with the Logic apps (preview) extension when im trying to open either the designer or overview views in VS code. Im running on WSL2 with Ubuntu. After reading some issues here for example https://github.com/Azure/logicapps/issues/201 so until Azurite or the logic apps team decide on anything else i had to create a Storage account in the Azure portal and set the "AzureWebJobsStorage": "DefaultEndpointsProtocol=.... ENV in both of the local.settings.json files.

So the Logic apps start up fine but i when i try to open the overview or the designer view the pane is completely empty image

Running it "natively" on windows with the same storage account the overview and designer view panes are working as expected.

is this a known issue that i have missed somewhere?

Bandgren commented 3 years ago

@ecfan Could this be that the Logic apps (preview) extension is not playing nice when VS code is running the remote extension to either a devcontainer or to WSL2? 🤔

ecfan commented 3 years ago

Hi @Bandgren,

I'm including the dev folks to help answer.

@rohithah and @laveeshb, any ideas why the designer and overview panes aren't opening?

laveeshb commented 3 years ago

@Bandgren -- can you trace network calls when you navigate to overview or designer view? We should check if any requests to fetch data to show on the designer are failing.

Bandgren commented 3 years ago

Hi, @laveeshb, @ecfan Thanks for the attention, i went ahead and made two network captures when i open the designer view. On a logic app preview project on windows we can see that all network calls works fine (image one). But on a logic app preview project running from WSL2 e.g via the remote extention in VS code we get a 404 when we the preview extention tries to call the following url: (image two)

http://172.27.91.56:42129/vscode-remote-resource?tkn=ef79fd15-f9c8-40fc-bb05-706f2902c5e4&path=%2Fhome%2Fbandgren%2F.vscode-server%2Fextensions%2Fms-azuretools.vscode-azurelogicapps-0.0.7%2Fdist%2Fdesigner%2Fdraft.min.js

I have also tried to uninstall and reinstall the extentions multiple times in the wsl2 instance.

Running the extention and project via a devcontainer i see the same 404 when the exntention is trying to GET the same uri but towards the devcontainer

http://127.0.0.1:36399/vscode-remote-resource?tkn=175de0be-6637-457b-b587-1f1ee370eb72&path=%2Froot%2F.vscode-server%2Fextensions%2Fms-azuretools.vscode-azurelogicapps-0.0.7%2Fdist%2Fdesigner%2Fdraft.min.js

windows

windows

wsl2

wsl2

WireShark PCAP files from the 2 captures. la_preview_designer_pcap_files.zip

EDIT:

When looking at the PATH that the exntentions is trying to go to in WSL

path=%2Froot%2F.vscode-server%2Fextensions%2Fms-azuretools.vscode-azurelogicapps-0.0.7%2Fdist%2Fdesigner%2Fdraft.min.js

And we get a 404 becouse the draft.min.js does not exists. But when i navigate to that path in WSL2 i can see that the file is acctually name Draft.min.sj e,g its with a CAPITAL d while the extentions is looking for the lowercase version. 😄 So i just tried to "rename" the files

cp Draft.min.js draft.min.js
cp Draft.js draft.js

The Desginer view now opens fine in VS code.

I guess this works "natively" on windows since Windows and Mac OSX are case insensitive while Linux is case sensitive

So i guess the files in the extention has to be renamed and shipped with the next release?

laveeshb commented 3 years ago

Thanks @Bandgren. We will have our team fix it for Linux.

laveeshb commented 3 years ago

@Bandgren We don't support the VS code based authoring tools on a Linux machine at this time but we do intend to add support for them in future. We have updated our docs to call it out -- https://docs.microsoft.com/en-us/azure/logic-apps/logic-apps-overview-preview#limited-unavailable-unsupported

joechung-msft commented 3 years ago

I merged the fix for the Draft script filename case. It will be included in the next extension release (0.0.9).

joechung-msft commented 3 years ago

0.0.9 is out now.