Azure / logicapps

Azure Logic Apps labs, samples, and tools
MIT License
364 stars 300 forks source link

UX: Parameter-Names with whitespaces cause problems but don't give error messages #800

Closed rubenaster closed 1 year ago

rubenaster commented 2 years ago

Within a Standard Logic App we've used a parameter name which includes a whitespace:

image

No problem, if it causes a problem, we can rename it.

But the issue was that saving the parameters works fine, saving a workflow works fine, no errors anywhere. But when you use the Logic App you notice that the workflow hasn't been compiled.

When you take a look at the Resource health and dig deeper into the menues you'll find the issue. But I would expect to already get an error when I try to save parameters with whitespaces.

AB#15951998

AB#24163535

zhangadreedom commented 2 years ago

Hi @rubenaster looks like the workflow designer check doesn't throw the template validation during the saving action. I can repro the same issue, let me to inform this with product team.

WenovateAA commented 2 years ago

I raised this issue before: https://github.com/Azure/logicapps/issues/471

Also opened a ticket. I was assured the fix will be issued somewhere in the end of March. I didn't get any confirmation that it was resolved yet

github-actions[bot] commented 1 year ago

This issue is stale because it has been open for 30 days with no activity.

preetriti1 commented 1 year ago

@hartra344 - we are missing an api at workflow app level to validate any artifact files, only in the context of any workflow we can use the validate api. Currently saving connections or parameters from their blade is just a file save call on the site resource.

preetriti1 commented 1 year ago

I am moving this issue to backend because we will need a validate api just on the artifact to make this working for the customers.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open for 45 days with no activity.

github-actions[bot] commented 1 year ago

This issue was closed because it has been inactive for 14 days since being marked as stale.