Azure / login

Connect to Azure
MIT License
295 stars 285 forks source link

v1.6.0 Creates warnings when doing azure/login from a composite action. #409

Open JasonRSeequent opened 8 months ago

JasonRSeequent commented 8 months ago

When calling azure/login@v1.6.0 from a composite action, the following warning is generated:

Warning: `pre` execution is not supported for local action from './.github/actions/deploy-infrastructure '

Example workflow block:

      - name: Deploy Infrastructure
        uses: ./.github/actions/deploy-infrastructure
        with:
          azure_credentials: ${{ secrets.AZURE_CREDENTIALS }}

Example action.yaml file:

name: "Deploy Infrastructure"

inputs:
  azure_credentials:
    description: "Azure service principle credentials"
    required: true

runs:
  using: "composite"
  steps:
    - name: Azure login
      uses: azure/login@v1
      with:
        creds: ${{ inputs.azure_credentials}}
MoChilia commented 8 months ago

Hi @JasonRSeequent, pre and post steps have not been supported in composite actions yet. This is a highly requested feature, let's track it in https://github.com/actions/runner/issues/1478.

JasonRSeequent commented 8 months ago

Hi @MoChilia, You are correct that pre and post steps are not currently supported in composite actions, based on the issue you linked, it doesn't look like they will be any time soon. If azure/login@v1 is supported in composite actions, then surely there should be a workaround to avoid having these warnings appear? The other workaround is to pin version v1.5.1, which isn't ideal.

MoChilia commented 8 months ago

@JasonRSeequent, it's a warning message and won't disrupt break your workflow, right? We'll explore ways to enhance this process, but it may not be of high priority. Thank you for your understanding.

ViktorDronov commented 7 months ago

this is not a high prio but annoying a lot of dev's around the world ;)

mrvamsidhar-ais commented 4 months ago

Any update on this?

ViktorDronov commented 2 months ago

any updates on this?

mrvamsidhar commented 2 months ago

FYI - I end up moving this task to my workflow.