uri encoding changes - Githubissues

Azure / meta-azure-service-broker

A service broker to manage multiple Azure services in Cloud Foundry

Apache License 2.0

39 stars 44 forks source link

uri encoding changes #141

Closed dave-read closed 7 years ago

dave-read commented 7 years ago

Changes to address connection issues described in Errors connecting to Azure PostgreSQL service when using VCAP_SERVICES parameters #140

Key changes:

Encode the individual URI Components using encodeURIComponent()
Set username property to username@servername
Replace global encoding of password with encoding only when in a URL/URI context

Note: it looks like similar changes may be needed for the MySQL service as well, since the logic in the bind operation there looks similar.

msftclas commented 7 years ago

@dave-read, Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA. Thanks, Microsoft Pull Request Bot

zhongyi-zhang commented 7 years ago

Thanks for your contribution! I will fix the same issue in MySQL module.