Azure / meta-azure-service-broker

A service broker to manage multiple Azure services in Cloud Foundry
Apache License 2.0
39 stars 44 forks source link

Added capability for unique identifiers when deploying multiple space-scoped instances of the broker #177

Closed mszcool closed 6 years ago

mszcool commented 6 years ago

When adding a service broker to a CF environment, Service IDs, Service Names and Plan IDs need to be unique for the entire Cloud Foundry environment.

In multi-tenant CF environment such as SAP Cloud Platform where multiple individual customers get their own organizations and spaces and don't have the permission to change global configurations, Service Brokers can only installed in a space-scoped fashion. In such cases, to enable customers making use of the Azure Meta Service Broker, the broker would need to automatically generate Service IDs, Service Names and Plan IDs which are unique to the entire CF environment to avoid conflicts with other customers who have an instance of the broker installed in their spaces with the option "--space-scoped", already.

Therefore, with this pull request, I've added a new option called SPACE_SCOPING_ENABLED. If Set to true, it will generate new Service IDs, Service Names and Plan IDs which are unique to the entire CF environment. Also display names are adjusted accordingly so that developers will be able to see, which services are installed space-scoped.

zhongyi-zhang commented 6 years ago

@mszcool thanks for this awesome contribution! I am on a vacation today. Will get it reviewed next Monday.

zhongyi-zhang commented 6 years ago

@mszcool merged. Thanks again for the contribution!