Azure / meta-iotedge

Yocto layer for Azure IoT Edge
MIT License
50 stars 59 forks source link

'master->main' branch renaming broke the recipes #78

Closed chli closed 2 years ago

chli commented 2 years ago

If any project out there still uses meta-iotedge please note that you will have to edit the recipes for iotedge-cli and iotedge-daemon to fetch the "main" branches for the following repositories:

git://github.com/Azure/hyperlocal-windows;protocol=https;nobranch=1;name=hyperlocal-windows;destsuffix=hyperlocal-windows \ git://github.com/Azure/mio-uds-windows.git;protocol=https;nobranch=1;name=mio-uds-windows;destsuffix=mio-uds-windows \ git://github.com/Azure/tokio-uds-windows.git;protocol=https;nobranch=1;name=tokio-uds-windows;destsuffix=tokio-uds-windows \

Must be changed to :

git://github.com/Azure/hyperlocal-windows;protocol=https;branch=main;name=hyperlocal-windows;destsuffix=hyperlocal-windows \ git://github.com/Azure/mio-uds-windows.git;protocol=https;branch=main;name=mio-uds-windows;destsuffix=mio-uds-windows \ git://github.com/Azure/tokio-uds-windows.git;protocol=https;branch=main;name=tokio-uds-windows;destsuffix=tokio-uds-windows \

Otherwise the automatic AUTOINC resolve fail since the 'master' branch got deleted (silently) on the 3 repositories above.

donofan0 commented 2 years ago

I made a Pull Request to fix this #79

emilm commented 2 years ago

Not good practice to just silently rename the main branch like that. Seems like I can't just override it in my own layer either, bitbake insists on parsing and process meta-iotedge files. How can this be fixed by overriding without messing up the submodule?

darobs commented 2 years ago

This was an unanticipated side-effect of changing the source repo's main branch. @donofan0's PR looks good, but the build failed due the agent running out of disk space. I cleaned up some disk space and re-ran the build. On success, I'll merge the PR.

I apologize for the problem.

darobs commented 2 years ago

PR #79 is merged, please try it now and let us know.

emilm commented 2 years ago

It builds!

darobs commented 2 years ago

Closing duplicates of this issue. There is still some discussion on #81.