Azure / mlops-v2

Azure MLOps (v2) solution accelerators. Enterprise ready templates to deploy your machine learning models on the Azure Platform.
https://learn.microsoft.com/en-us/azure/machine-learning/concept-model-management-and-deployment
MIT License
516 stars 258 forks source link

[repo] Automate service principal setup? #24

Closed lostmygithubaccount closed 1 year ago

lostmygithubaccount commented 2 years ago

Why?

Currently the QUICKSTART.md includes a lengthy setup through the GUI for creating a couple Service Principals for use later. Can't this be automated with the Azure CLI? Then this section can simply be to run a script or can be included in the infrastructure setup.

How?

Probably a series of az ad sp commands. Should be idempotent.

Anything else?

A user also needs to ensure they're using the same names. All of this should go in a configuration file and get used throughout the project. @dkmiller may have some thoughts here too, perhaps that hydra tool would be good here?

lostmygithubaccount commented 2 years ago

for reference: https://github.com/Azure/azureml-examples/blob/main/setup-repo/azure-github.sh#L47

lostmygithubaccount commented 2 years ago

Additionally this is instructing contributor access for the SPs on the subscription. This should probably be scoped to resource group, which I think should be created as part of the infrastructure setup.