search

Azure / mobile-services-samples

Apache License 2.0
93 stars 259 forks source link

Fix/offline sync #45

Closed cesine closed 9 years ago

cesine commented 9 years ago

Connected Offline Sync sample to same webservice as the online example, now we can see data pulled down from the service.

ggailey777 commented 9 years ago

@lindydonna can you take a look at this update? Do we want to have a real service URL in the sample?

cesine commented 9 years ago

@ggailey777 @lindydonna if there is a problem with using the URL, i can easily remove it but the other two commits are still needed in order for the sample to run. (although having the sample with no-url makes it kind of useless as a tool for understanding how the tables are constructed and the requirements to get the tables to build since the only way we figured out how to build our service was by running against a working server side)

ggailey777 commented 9 years ago

@cesine Can you just add a note for the constructor reminding folks that they need to replace with their own service URL and app key? Also please address the other comments from @phvannor .

cesine commented 9 years ago

Thanks @phvannor and @ggailey777 for looking into this PR :)

I added the note to remind folks to use their own service URL, and spent some time adding some screenshots and db dumps to address @phvannor 's comments.

i'm kind of busy with other stuff so I hope i provided enough info to convince you that these changes are useful :)

phvannor commented 9 years ago

:+1: I'm ok with this. Would like to understand why __deleted is needed in the local data model, but thats not a blocker on this PR and sounds like a bug for our team to investigate.

lindydonna commented 9 years ago

@cesine thanks for the PR and for addressing the feedback! @soninaren will look into the possible Android bug--thanks for the detailed info so that we can repro.

soninaren commented 9 years ago

Looks like the app was using a really old version of the SDK, there is a new GA version of the SDK. Pull works fine when testing with the new version. Also I have updated the app to use Android Studio.