search

Azure / ms-rest-js

Runtime for isomorphic javascript libraries generated by Autorest
MIT License
55 stars 57 forks source link

`RestError` class no longer matches the instance thrown via `botbuilder` message sends #490

Open Hyokune opened 1 month ago

Hyokune commented 1 month ago

Package Version: 2.7.0

Describe the bug We are currently using the botbuilder to send message via Microsoft Teams however we are checking the instance of the error to match the RestError provided from here to ensure that we are handling known exceptions from the API.

This seems to have been working fine until this week where the thrown error no longer matches the instance.

To Reproduce Steps to reproduce the behavior:

  1. Setup CloudAdapter from botbuilder
  2. Send a message to a user who has blocked the MS teams bot, using continueConversationAsync from the adapter
  3. Check the error thrown

Expected behavior The RestError class instance should match the error thrown via the Rest API

jeremymeng commented 1 month ago

@Hyokune Seems that botbuilder migrated to use @azure/core-http. Could you try using RestError from @azure/core-http instead?