Added support to use azure-cli credentials from the JS sdk

Azure / ms-rest-nodeauth

node.js based authentication library for Azure with type definitions

MIT License

33 stars 33 forks source link

Added support to use azure-cli credentials from the JS sdk #55

Closed amarzavery closed 5 years ago

amarzavery commented 5 years ago

Fixes

amarzavery commented 5 years ago

@jacob-ebey, @zommarin - Please review.

jacob-ebey commented 5 years ago

Looks good to me. I don't have the capacity to test this locally at the moment but can tomorrow. I reviewed the code and ran the az commands you are executing and my local output matches the interfaces.

What is your release process like? Do you go to a alpha package once approved?

amarzavery commented 5 years ago

Hey @jacob-ebey - Thanks for reviewing the PR. Feel free to test it locally as per your convenience.

Once the PR is approved and merged to master, the package will be published to npm for consumption.

rfink commented 5 years ago

Is there an example of using this with the new azure-sdk-for-js? Can't seem to find it anywhere.