Add clientid param to MSIAppServiceOptions

Azure / ms-rest-nodeauth

node.js based authentication library for Azure with type definitions

MIT License

33 stars 33 forks source link

Add clientid param to MSIAppServiceOptions #85

Closed emily-curry closed 4 years ago

emily-curry commented 4 years ago

Fixes #79, allows for a clientid param to be provided to MSIAppServiceOptions so that code in App Service may generate credentials using a user-assigned managed identity.

Usage of WebResource.prepare within prepareRequestOptions has been mimicked from #59 for consistency. Structure of headers/params in the request has been based on the app-service/overview-managed-identity page.

msftclas commented 4 years ago

All CLA requirements met.

emily-curry commented 4 years ago

CI failures are due to typescript compiler changes unrelated to my changes (and no lockfile is in version control). Changed typescript version from caret range to tilde range 3.5.3, since this package is being deprecated I thought that acceptable.

ramya-rao-a commented 4 years ago

Looks good to me. I'll let @daviwil take another look and we can merge. After which @sadasant has some clean up planned for readme and samples before we release

Thanks for the PR @emily-curry! And thanks for your patience with us as well