search

Azure / msrest-for-python

The runtime library "msrest" for AutoRest generated Python clients.
MIT License
41 stars 64 forks source link

"Accept header absent and forced to application/json" log spam #109

Closed dharmab closed 6 years ago

dharmab commented 6 years ago

102 introduced code which ensured the "Accept" header is always set to "application/json". However, it also introduced a WARNING level log that causes a lot of spam in applications using the Azure SDK.

This makes it really had to read application logs; here's an example of an Azure deployment in Jenkins:

image

lmazuel commented 6 years ago

Hum, I guess you're right. With new SDK, this warning will not be seen, but since there is more "old" SDKs released than new ones, that's probably fair. Let's do a debug for now as you suggest, but in a 6 months timeframe, I should put him back to "warning". This is to warn about a wrong assumption made by old generators that the entire world is JSON (even if it's not). New generated SDKs are more precise, and able to deal with XML. Thanks for the PR!