search

Azure / msrest-for-python

The runtime library "msrest" for AutoRest generated Python clients.
MIT License
41 stars 64 forks source link

Strip BOM from JSON responses #145

Closed eduardomourar closed 5 years ago

eduardomourar commented 5 years ago

@lmazuel and @susam, this fixes issue #144.

codecov-io commented 5 years ago

Codecov Report

Merging #145 into master will increase coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #145      +/-   ##
==========================================
+ Coverage   88.01%   88.02%   +0.01%     
==========================================
  Files          25       25              
  Lines        2561     2564       +3     
==========================================
+ Hits         2254     2257       +3     
  Misses        307      307
Impacted Files Coverage Δ
msrest/universal_http/__init__.py 75.91% <100%> (ø) :arrow_up:
msrest/pipeline/universal.py 94.79% <100%> (+0.16%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update adb4596...f55b930. Read the comment docs.

lmazuel commented 5 years ago

Hi @eduardomourar ! Thanks the contribution! I definitely acknowledge there is an issue to fix here (we'll merge your PR eventually). I added a few comments / questions for your review. Thanks!

lmazuel commented 5 years ago

Thanks @eduardomourar again for the contribution! The next release date is unsure yet, but this will be in it for sure ;)