Closed ross closed 1 year ago
Merging #182 into master will decrease coverage by
0.02%
. The diff coverage is50%
.
@@ Coverage Diff @@
## master #182 +/- ##
==========================================
- Coverage 87.89% 87.86% -0.03%
==========================================
Files 25 25
Lines 2593 2595 +2
==========================================
+ Hits 2279 2280 +1
- Misses 314 315 +1
Impacted Files | Coverage Δ | |
---|---|---|
msrest/serialization.py | 91.03% <50%> (-0.09%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update b505e36...5d8dd43. Read the comment docs.
https://github.com/github/octodns/pull/384 added py3 support
Nm. Closed one too many tabs worth. This still applies.
As this project is now deprecated, closing.
Ran into this problem with the Azure DNS provider when updating octoDNS to support Python 3 in https://github.com/github/octodns/pull/384. It looks like objects that implement
__eq__
in Python 3 are also required to implement a custom__hash__
method to match.RecordSet
inazure-mgmt-dns==3.0.0
inherits fromModel
leading to:I haven't dug around to see if there are other objects in
msrest
that need similar updates.The actual hashing logic seems reasonable to me, but I'd welcome suggested improvements.