Azure / msrest-for-python

The runtime library "msrest" for AutoRest generated Python clients.
MIT License
41 stars 64 forks source link

Additional properties and XML detection is flawed #207

Open lmazuel opened 4 years ago

lmazuel commented 4 years ago

To build the additional properties set, we need to know what was consumed by the extractors to build the final object. What was NOT consumed, will go to the additional property bag.

We don't have a nice way to know what was consumed today, so we guessed it by introspecting the model built so far. This works ok for JSON, since this is simple key matching, but it doesn't work for XML:

Result impact is a bloated additional property bag, with too many things.

This is complex to fix, and have little impact on usability right now, so keeping it as "enhancement" until someone really wants an additional property set that is perfect (and then needs slightly improved design for XML)