search

Azure / msrest-for-python

The runtime library "msrest" for AutoRest generated Python clients.
MIT License
41 stars 64 forks source link

Don't log Authorization header in http request #21

Closed mideeks closed 7 years ago

mideeks commented 7 years ago

Keep secrets out of debug logs whenever possible. Prevents copy/paste accidents.

codecov-io commented 7 years ago

Codecov Report

Merging #21 into master will increase coverage by 0.04%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
+ Coverage   71.16%   71.21%   +0.04%     
==========================================
  Files           9        9              
  Lines        1186     1188       +2     
==========================================
+ Hits          844      846       +2     
  Misses        342      342
Impacted Files Coverage Δ
msrest/http_logger.py 74.41% <100%> (+1.24%) :white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5c78216...f45db1b. Read the comment docs.

lmazuel commented 7 years ago

Thank you @mideeks !