search

Azure / msrest-for-python

The runtime library "msrest" for AutoRest generated Python clients.
MIT License
41 stars 64 forks source link

Added decimal type as object #225

Closed ludokriss closed 3 years ago

ludokriss commented 4 years ago

Added decimal types in addition to the datetime types you have provided.

Don't know if you want me to do this, but thought it wouldn't cost you much to reject if you would like a different implementation.

ghost commented 4 years ago

CLA assistant check
All CLA requirements met.

codecov-commenter commented 4 years ago

Codecov Report

Merging #225 into smart_obj will increase coverage by 0.04%. The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           smart_obj     #225      +/-   ##
=============================================
+ Coverage      85.78%   85.83%   +0.04%     
=============================================
  Files             25       25              
  Lines           2687     2689       +2     
=============================================
+ Hits            2305     2308       +3     
+ Misses           382      381       -1
Impacted Files Coverage Δ
msrest/serialization.py 90.11% <100.00%> (+0.11%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b5d2aac...ef49f10. Read the comment docs.

lmazuel commented 3 years ago

Sorry for the late answer, missed it somehow, but the change LGTM. Thanks for the contribution!