search

Azure / msrest-for-python

The runtime library "msrest" for AutoRest generated Python clients.
MIT License
41 stars 64 forks source link

bug: minor fix on handling micro-second precisions #82

Closed yugangw-msft closed 6 years ago

yugangw-msft commented 6 years ago

2 notes:

  1. I agree with the chopping logic, but we should ensure <=6 digits. Python's datetime object will error out when you supply more than that
  2. I am also a bit skeptical on the float conversion which might miss a bit precision say from .555 to .549999. But I don't have good context on that as we might have good reasons to do that.

//CC: @lmazuel @annatisch

codecov-io commented 6 years ago

Codecov Report

Merging #82 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #82   +/-   ##
=======================================
  Coverage   78.05%   78.05%           
=======================================
  Files         273      273           
  Lines       14292    14292           
=======================================
  Hits        11155    11155           
  Misses       3137     3137
Impacted Files Coverage Δ
msrest/serialization.py 82.31% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7cce81e...718a583. Read the comment docs.