Azure / ng-deploy-azure

Deploy Angular apps to Azure using the Angular CLI

MIT License

79 stars 37 forks source link

fixing compilation errors that happened due to dep packages update, w… #31

Closed softchris closed 5 years ago

softchris commented 5 years ago

…e should consider locking down version

Pull Request Template

Description

Some dep packages had changed their signature so needed these code changes to make everything compile

Type of change

Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How to Test

On master branch:

remove your node_modules
npm install
tsc -w

The above should produce compilation errors on the master branch However, with these code fixes, there should no longer be an error

Closing issues

Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

Assignee

Please add yourself as the assignee

Projects

Please add relevant projects so this issue can be properly tracked.