Azure / ng-deploy-azure

Deploy Angular apps to Azure using the Angular CLI

MIT License

79 stars 37 forks source link

fix: issue where it generates names for all eternity #62

Closed softchris closed 4 years ago

softchris commented 4 years ago

Pull Request Template

Description

this fixes an issue where this piece of code ended up in while/true

function accountNameGenerator(client: StorageManagementClient) {
  return async (name: string) => {
    return await generateName(name, checkNameAvailability(client, false));
  };
}

Type of change

Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How to Test

place a console.log inside of checkNameAvailability() and you will see this being hit thousands of times

Closing issues

Closes #60