search

Azure / ng-deploy-azure

Deploy Angular apps to Azure using the Angular CLI
MIT License
79 stars 37 forks source link

Telemetry #70

Closed shmool closed 4 years ago

shmool commented 4 years ago

Pull Request - App Insights

Description

Added Azure ApplicationInsights SDK, collecting default telemetry. Saving the user's choice whether to allow telemetry. Introducing environment JSONs.

Type of change

Please delete options that are not relevant.

How to Test

Open an Application Insights service on Azure. Add its Instrumentation Key to environment.dev.json or environment.test.json as "insightsKey". Test the app regularly (ng add and ng deploy). Check whether the http requests were recorded in the App Insights. Make sure it's recorded when not using the telemetry flag, or when using it with true, and not when using it with false. The choice of telemetry should be added to angular.json under the deploy section.

Closing issues

Closes #32

manekinekko commented 4 years ago

@shmool can you rebase your changes on master and update your commit messages?

shmool commented 4 years ago

Continuing in a new PR: https://github.com/Azure/ng-deploy-azure/pull/71