nxPackage: Fix Set-operation hanging for apt-packages

janegilring commented 1 year ago

Pull Request (PR) description

This PR adds a -Force parameter to Install-nxAptPackage and Install-nxPackage to make it possible to supply the confirmation parameter --yes to apt install when using the commands interactively. It also adds Force = $true in the nxPackage resource in order to suppress the confirmation promt in unattended DSC invocations.

This Pull Request (PR) fixes the following issues

Fixes #19

Task list

[ x ] Added an entry to the change log under the Unreleased section of the file CHANGELOG.md. Entry should say what was changed and how that affects users (if applicable), and reference the issue being resolved (if applicable).
[ x ] Resource documentation added/updated in README.md.
[ x ] Comment-based help added/updated.
[ x ] Localization strings added/updated in all localization files as appropriate.
[ x ] Examples appropriately added/updated.
[ x ] Unit tests added/updated. See DSC Community Testing Guidelines.
[ x ] Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
[ x ] New/changed code adheres to DSC Community Style Guidelines.

gaelcolas commented 1 year ago

Looks good to me, although in the current state, iirc, if Force is not set it would just hang. Is there a --no we could default to to fail the operation?

janegilring commented 1 year ago

Looks good to me, although in the current state, iirc, if Force is not set it would just hang. Is there a --no we could default to to fail the operation?

Good question. It seems like there are no --no parameter, but maybe it could be better to default to --simulate if -Force is not set to $true?

Ref: https://linuxcommandlibrary.com/man/apt-get

Azure / nxtools