After going back and forth with the ARM folks a bit, I've realized that a previous update to oav was incorrect. Not only that, but we have some additional suppression logic that applies only to the ARM team ported in this PR as well.
This PR:
Enables arm-id format validation in all cases.
INVALID_FORMAT errors will be suppressed and only logged when isArmCall == false. In practice, isArmCall = false during liveValidation, which only applies to the ARM validation image currently.
Resolve erroneously suppressed additionalProperties errors in operationValidator.ts. isArmCall=true in all cases of Model Validation and Semantic Validation, which means this suppression was backwards before this PR. A full regression build of this changeset will be checked against azure-rest-api-specs to see if anything has slipped through while this is disabled.
Add unit test to check suppression of INVALID_FORMAT error during live validation.
After going back and forth with the ARM folks a bit, I've realized that a previous update to
oavwas incorrect. Not only that, but we have some additional suppression logic that applies only to the ARM team ported in this PR as well.This PR:
arm-idformat validation in all cases.INVALID_FORMATerrors will be suppressed and only logged whenisArmCall == false. In practice,isArmCall = falseduringliveValidation, which only applies to the ARM validation image currently.additionalPropertieserrors inoperationValidator.ts.isArmCall=truein all cases ofModel ValidationandSemantic Validation, which means this suppression was backwards before this PR. A full regression build of this changeset will be checked againstazure-rest-api-specsto see if anything has slipped through while this is disabled.INVALID_FORMATerror during live validation.