search

Azure / open-service-broker-azure

The Open Service Broker API Server for Azure Services
https://osba.sh
MIT License
248 stars 100 forks source link

Service catalog should return a sorted list of plans #267

Closed ritazh closed 6 years ago

ritazh commented 6 years ago

For example, this is defined by the service broker, in this case sort by DTUs: https://github.com/Azure/open-service-broker-azure/blob/master/pkg/services/mysqldb/catalog.go

krancour commented 6 years ago

It might not be obvious, but the catalog you're pointing to is sorted first by tier and then by "size" (DTUs, in this case) within the tier. imo, DTUs are of secondary importance to tier because while you can increase or decrease DTUs within a tier, you cannot move between tiers. i.e. Once you pick a tier, you're locked into it.

arschles commented 6 years ago

@krancour the service-catalog might not be sorting by anything that the broker returns? i.e. my thought is that when you do a svcat get plans the Kube API might be returning the ClusterServicePlans by their Kube resource names, which are UUIDs.

Thoughts?

krancour commented 6 years ago

@arschles I'm fairly certain that is the case.

krancour commented 6 years ago

So is this an issue for kubernetes-incubator/service-catalog instead?

ritazh commented 6 years ago

I can create the issue there, just wanted to make sure this is a catalog issue, not the broker.

jeremyrickard commented 6 years ago

I opened an issue for svcat to sort (i'm working on it this week).

See https://github.com/kubernetes-incubator/service-catalog/issues/1703

ritazh commented 6 years ago

@jeremyrickard I think it's great to have svcat return a sorted list...I was thinking more at the api level so when we query the api, it would return the sorted list of plans as implemented by the broker.

krancour commented 6 years ago

It's still not clear to us what value this provides at the broker level and we're also not really sure how we'd implement it. Closing.