Add VNET rules to PostgreSQL

Azure / open-service-broker-azure

The Open Service Broker API Server for Azure Services

https://osba.sh

MIT License

248 stars 100 forks source link

Add VNET rules to PostgreSQL #676

Closed timja closed 5 years ago

timja commented 5 years ago

Closes #667

Manually tested:

azure-postgresql-10-dbms
azure-postgresql-10

Added life cycle test coverage as well

timja commented 5 years ago

Is it expected that lint should take greater than 10 minutes locally?

$ docker ps
CONTAINER ID        IMAGE                                       COMMAND                  CREATED             STATUS              PORTS                    NAMES
18c8f9e10e0e        quay.io/deis/lightweight-docker-go:v0.2.0   "gometalinter ./... …"   11 minutes ago      Up 11 minutes                                sad_almeida

Tests etc executed at a reasonable speed for me, but lint was ridiculous, I thought it wasn't working so kept cancelling it

zhongyi-zhang commented 5 years ago

Not expected to be so long. I kicked off the CI. The lint test result looks good. Again thanks for the contribution! I'll look into the code change later.