search

Azure / open-service-broker-azure

The Open Service Broker API Server for Azure Services
https://osba.sh
MIT License
248 stars 101 forks source link

Including Eventhub name and namespace in the returning credentials #691

Closed aljannuzzi closed 5 years ago

aljannuzzi commented 5 years ago

Fixes #685 I described this minor change as WIP to understand what kind of tests I am required to execute. Including the EventHub name and namespace in the secrets file generated after the binding operation makes it easier to access and use the created environment.

zhongyi-zhang commented 5 years ago

@aljannuzzi you can follow this section to do the tests. Before merging a PR, we'll also run them via CircleCI. And if you add test for the bound credentials here, that would be better. MySQL credentials test as a reference: https://github.com/Azure/open-service-broker-azure/blob/master/tests/lifecycle/mysql_cases_test.go#L76-L114.

aljannuzzi commented 5 years ago

@zhongyi-zhang - could you please review this change - I made some minor changes - removed unnecessary conversion and used gomft. If it passes, would that be ok to merge it while I open an issue to work in parallel on the life-cycle tests?

zhongyi-zhang commented 5 years ago

Of course, thanks for your contribution! I'll merge it once the CI passes.