search

Azure / open-service-broker-azure

The Open Service Broker API Server for Azure Services
https://osba.sh
MIT License
248 stars 100 forks source link

Add API key binding to Application Insights #702

Closed kyschouv closed 5 years ago

kyschouv commented 5 years ago

To be able to access application insights from Grafana, we need an API key. It would be awesome if this could be provisioned with the App Inisghts resource through osba, rather than having to write something separate to create and manage it.

zhongyi-zhang commented 5 years ago

I am happy to do adding this. But I hit an issue deleting API key with Azure Go SDK in unbinding. Tracking https://github.com/Azure/azure-sdk-for-go/issues/4993.

kyschouv commented 5 years ago

Thanks for the quick resolution! When's the next release scheduled?

zhongyi-zhang commented 5 years ago

Here it is! https://github.com/Azure/open-service-broker-azure/releases/tag/v1.7.0

kyschouv commented 5 years ago

Thanks! Should I wait for the new helm chart, or is it safe to just upgrade the image version from 1.6.0 to 1.7.0?

zhongyi-zhang commented 5 years ago

A new version of the chart was also published by our release pipeline. Feel free to have a try:). Feedback is welcome.

kyschouv commented 5 years ago

Excellent! Deployed fine! Is there a way to update current bindings, or do I need to redeploy those?

zhongyi-zhang commented 5 years ago

Yes, please delete the old app insights instances and create a new one. Because the PR brings in appID as a new property of instance in broker store. Binding for the old instances can't find it and would fail.