Open cataggar opened 9 months ago
I'm working on https://github.com/Azure/azure-rest-api-specs-pr/pull/15631 . I have 57 ChangedParameterOrder breaking change errors. Many are due to ApiVersionParameter changing order. It should be ignored by the ChangedParameterOrder rule.
ChangedParameterOrder
ApiVersionParameter
This is the original.
"operationId": "Locations_CheckQuotaAvailability", "parameters": [ { "$ref": "../../../../../common-types/resource-management/v3/types.json#/parameters/SubscriptionIdParameter" }, { "name": "location", "in": "path", "required": true, "type": "string", "description": "Azure region" }, { "$ref": "../../../../../common-types/resource-management/v5/types.json#/parameters/ApiVersionParameter" } ],
To:
"operationId": "Locations_CheckQuotaAvailability", "parameters": [ { "$ref": "../../../../../common-types/resource-management/v3/types.json#/parameters/ApiVersionParameter" }, { "$ref": "../../../../../common-types/resource-management/v3/types.json#/parameters/SubscriptionIdParameter" }, { "name": "location", "in": "path", "description": "A location in a subscription", "required": true, "type": "string", "pattern": "^[-\\w\\._]+$" } ],
If I move the ApiVersionParameter in the original version to be first, the rule does not consider it breaking.
Also reported here: https://github.com/Azure/azure-sdk-tools/issues/7170
I'm working on https://github.com/Azure/azure-rest-api-specs-pr/pull/15631 . I have 57
ChangedParameterOrder
breaking change errors. Many are due toApiVersionParameter
changing order. It should be ignored by theChangedParameterOrder
rule.ChangedParameterOrder
This is the original.
To:
If I move the ApiVersionParameter in the original version to be first, the rule does not consider it breaking.