Add new rule: `1050 - ParameterLocationHasChanged`; Change behavior of `ChangedParameterOrder` rule with regards to `x-ms-parameter-location` - Githubissues

Azure / openapi-diff

Command line tool to detect breaking changes between two openapi specifications

MIT License

253 stars 34 forks source link

Add new rule: `1050 - ParameterLocationHasChanged`; Change behavior of `ChangedParameterOrder` rule with regards to `x-ms-parameter-location` #334

Closed konrad-jamrozik closed 1 month ago

konrad-jamrozik commented 1 month ago

Addresses:

https://github.com/Azure/azure-sdk-tools/issues/7170

konrad-jamrozik commented 1 month ago

@mikekistler can you review and approve?

Comment 1: https://github.com/Azure/openapi-diff/pull/334/files#r1646885090
Comment 2: https://github.com/Azure/openapi-diff/pull/334/files#r1646886636

konrad-jamrozik commented 1 month ago

@mikekistler I applied the changes per our chat. Please see the diff for all the changes. Notably:

New rule: https://github.com/Azure/openapi-diff/blob/users/kojamroz/param_order/docs/rules/1050.md
Unit test: public void ParameterLocationChanged()
See my comment here

konrad-jamrozik commented 1 month ago

Pull Request 559774: Update @azure/oad to 0.10.11 + rush update

konrad-jamrozik commented 1 month ago

Deployed to Production: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=9767803&view=results

Test PR:

https://github.com/test-repo-billy/azure-rest-api-specs/pull/3371