Add reusable HVAC components

Azure / opendigitaltwins-building

Open Digital Twins Definition Language (DTDL) RealEstateCore Ontology

MIT License

155 stars 44 forks source link

Add reusable HVAC components #18

Closed rszcodronski closed 3 years ago

rszcodronski commented 3 years ago

Created HVACCoolingMethod and HVACHeatingMethod which are Components used for many HVAC equipment
Created HVACMixingBox which is a Component of an AirHandlingUnit (potential to be used in future HVAC models)
Refactored AirHandlingUnit, FanCoilUnit, VAVBox, UnitHeater to use the new Components

ghost commented 3 years ago

All CLA requirements met.

rszcodronski commented 3 years ago

Pushed new commits to address @hammar and @briancr-ms comments.

hammar commented 3 years ago

I've now regenerated the DTDL models from the underlying OWL representation (and in the process found a number of regressions in those underlying models due to a version management mishap, so good that I had to do that!). I've run the regenerated models through the DTDL Validator and they are valid. I'm OK with proceeding on this.