Adding Space Components and add ICT equipments

Azure / opendigitaltwins-building

Open Digital Twins Definition Language (DTDL) RealEstateCore Ontology

MIT License

155 stars 44 forks source link

Adding Space Components and add ICT equipments #20

Closed alinamstanciu closed 3 years ago

alinamstanciu commented 3 years ago

Added Space components as done by Rick in this PR https://github.com/WillowInc/opendigitaltwins-building/commit/c3eba4045e41527a2421a9fe68b671aab0564234
Add more ICT equipment as done by Rick in this PR https://github.com/WillowInc/opendigitaltwins-building/commit/d672c28b9ddfaaf8a3100015fd88741a4cb1ef9d

Rick, next time when you add something generic, I think it's worth pinging us if it could sit in this main repo

akshayj-MSFT commented 3 years ago

The folders under Asset\Equipment have the word "Equipment" tacked onto each folder - this seems overkill. I prefer the Willow way which has Equipment

Conveyance
Electrical
Fire Protection
HVAC
ICT
Lighting
etc

Would it be possible to make a similar change as part of this PR?

alinamstanciu commented 3 years ago

Hi @rszcodronski and @akshayj-MSFT , could you please revisit? Addressed all your feedback Thanks

akshayj-MSFT commented 3 years ago

@alinamstanciu Top level Equipment interfaces should go inside their respective folder. e.g. ConveyanceEquipment,json should move to Conveyance folder same for ElectricalEquipment, FireProtectionEquipment, etc, etc, etc

hammar commented 3 years ago

Status update: I've set aside Friday for work on this (and on the externalIds feature) and will return the review then. Pardon the delay.

alinamstanciu commented 3 years ago

@rszcodronski , any more feedback I need to address, if not, could you please approve? Thanks

alinamstanciu commented 3 years ago

I haven't made any changes to the files/folders yet @rszcodronski