Closed alinamstanciu closed 3 years ago
The folders under Asset\Equipment have the word "Equipment" tacked onto each folder - this seems overkill. I prefer the Willow way which has Equipment
Would it be possible to make a similar change as part of this PR?
Hi @rszcodronski and @akshayj-MSFT , could you please revisit? Addressed all your feedback Thanks
@alinamstanciu Top level Equipment interfaces should go inside their respective folder. e.g. ConveyanceEquipment,json should move to Conveyance folder same for ElectricalEquipment, FireProtectionEquipment, etc, etc, etc
Status update: I've set aside Friday for work on this (and on the externalIds feature) and will return the review then. Pardon the delay.
@rszcodronski , any more feedback I need to address, if not, could you please approve? Thanks
I haven't made any changes to the files/folders yet @rszcodronski
Rick, next time when you add something generic, I think it's worth pinging us if it could sit in this main repo