Azure / opendigitaltwins-building

Open Digital Twins Definition Language (DTDL) RealEstateCore Ontology
MIT License
155 stars 44 forks source link

"dtmi:digitaltwins:rec_3_3:asset:Server;1" extends missing "dtmi:digitaltwins:rec_3_3:asset:ITHardware;1" #22

Closed nazar-kuzo closed 3 years ago

nazar-kuzo commented 3 years ago

Current ontology models failed validation due to "dtmi:digitaltwins:rec_3_3:asset:Server;1" (Asset\Equipment\ICT\ITHardwareEquipment\Server.json) extends missing "dtmi:digitaltwins:rec_3_3:asset:ITHardware;1".

I assume there is a typo and it should reference "dtmi:digitaltwins:rec_3_3:asset:ICTHardware;1" (Asset\Equipment\ICT\ITCHardware.json), but there is one more inconsistency, file name (ITCHardware) is not matching the declaring interface (ICTHardware).

akshayj-MSFT commented 3 years ago

Thanks for reporting this.

Fixed this with this commit: https://github.com/Azure/opendigitaltwins-building/commit/cb93b123fdd7d552784996232ff1ee06ee1b99e4