search

Azure / opendigitaltwins-building

Open Digital Twins Definition Language (DTDL) RealEstateCore Ontology
MIT License
155 stars 44 forks source link

Remove Space Components from TenantUnit and rename occupancy to isOccupied #24

Closed alinamstanciu closed 3 years ago

alinamstanciu commented 3 years ago

see email

  1. SpaceCapacity and SpaceArea components – a. Agree with Karl about it only being on Space and not on TenantUnit b. ACTION: Remove Space Components from TenantUnit (in the REC ontology) . Owner: @Alina Stanciu
  2. SpaceCO2, SpaceHumidity, SpaceTemperature Property Components Or Capabilities a. We saw the use of these as BOTH valid – as aggregate Temperature on a Floor AND as a Capability on Floor for Temperature (using TemperatureSensor) b. ACTION: DO NOTHING. Both of these models are allowable by the Ontology today, and we should leave it up to the developer of how they want to use it. They might choose the Capability route or the Property route
  3. SpaceOccupancy Component a. We do need both PeopleCount and Occupancy (since there are sensors that do ONE or the OTHER or sometimes both) b. Agree with Karl about the “occupancy” not signifying a Boolean value. c. ACTION: Proposed name change: “isOccupied” . Owner: @Alina Stanciu (in the REC ontology) and @Rick Szcodronski (in the Willow ontology)
rick commented 3 years ago

rszcodronski commented 3 years ago

Should the "inferredOccupancy" boolean also be updated to something like "hasInferredOccupancy"?

hammar commented 3 years ago

Holding off on review since this is being discussed on a parallell email thread. Let me know if the debate should be moved here instead.