search

Azure / opendigitaltwins-building

Open Digital Twins Definition Language (DTDL) RealEstateCore Ontology
MIT License
155 stars 44 forks source link

Adding Brick Sensors #29

Open alinamstanciu opened 3 years ago

alinamstanciu commented 3 years ago

Adding Brick Sensors

briancr-ms commented 3 years ago

To be consistent with the rest of the ontology, I think most of these models should move one directory level up. For example, TemperatureSensor.json should be in the Sensor folder. Then the TemperatureSensor folder should contain any specializations of TemperatureSensor.

alinamstanciu commented 3 years ago

@briancr-ms , as far as your comment "To be consistent with the rest of the ontology, I think most of these models should move one directory level up. For example, TemperatureSensor.json should be in the Sensor folder. Then the TemperatureSensor folder should contain any specializations of TemperatureSensor.", here is my answer. We've decided with Karl and everyone else to move all files under dedicated folder (e.g. TemperatureSensor.json) first because it's easier, second because our ModelUploader was fixed to not require these files to be outside of folders so they can process first. Based on this decision, I've decided to not move them outside of the folders, soon everything will be moved into dedicated folder. Thanks

alinamstanciu commented 3 years ago

@briancr-ms , @rszcodronski can you please revisit? I've addressed your comments. Thanks!