search

Azure / opendigitaltwins-building

Open Digital Twins Definition Language (DTDL) RealEstateCore Ontology
MIT License
157 stars 44 forks source link

Add externalIDs on all relationships #41

Open alinamstanciu opened 3 years ago

alinamstanciu commented 3 years ago

Hi Karl @hammar ,

@davidemassarenti has a feedback on Relationships we have added in REC models. When uploading BMS data into ADT, he is using externalIds property to modify only twins which are coming from BMS. He is saying that we need relationships to have “externalIds” property. I am proposing we should add it on all relationships.

Thanks

erikoskarwallin commented 3 years ago

Alina,

From rdfs:comments in 3.3 regarding property “hasAliasIdD" "Was originally intented to map an Id in an external system to an instance (e.g. an UUID). After discussion in REC technical committee, an approach based on owl:sameAs and/or rdfs:seeAlso (depending on the needed semantics) is recommended instead. This property will therefore be removed in future versions."

We still support hasAliasID in ProptechOS and use it to map different system’s namespaces.

We chose AliasID rather that ExternalID (≈externalIds) , since “external” depends if you are on the inside or outside.

Best,

erik

On 26 May 2021, at 19:17, Alina Stanciu @.***> wrote:

Hi Karl @hammar https://github.com/hammar ,

@davidemassarenti https://github.com/davidemassarenti has a feedback on Relationships we have added in REC models. When uploading BMS data into ADT, he is using externalIds property to modify only twins which are coming from BMS. He is saying that we need relationships to have “externalIds” property. I am proposing we should add it on all relationships.

Thanks

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Azure/opendigitaltwins-building/issues/41, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB3MMAKEV2HSAQFCDE7H5VDTPUUI3ANCNFSM45SQI56A.