search

Azure / opendigitaltwins-building

Open Digital Twins Definition Language (DTDL) RealEstateCore Ontology
MIT License
150 stars 42 forks source link

New asset properties and models #52

Closed rszcodronski closed 2 years ago

rszcodronski commented 2 years ago

Adding new asset properties and models based on gaps the Willow implementation team has identified.

rszcodronski commented 2 years ago

Most of these things are straight forward and I have already implemented them in the OWL models, and could regenerate DTDL from that.

I'm a little less certain about the changes to the meters -- it seems we are changing their properties to no longer represent the accumulated value of whatever they are measuring, and instead are adding properties relating to how they are rated/what they can measure. Is that a correct interpretation? Might there not be use also for properties which actually describe the accumulated value reading of the meter? It's not my home field, so I'd just like to double-check before proceeding on these.

Yes, your understanding is exactly correct. I realized that our meter models still had the "telemetry" properties of what it is measuring, but we have since introduced the Capability models which is where these values should be setup and trended just like every other asset that has associated telemetry.

The properties which I've left or updated are the actual rating or capacity of the meter based on its specifications.

hammar commented 2 years ago

Most of these things are straight forward and I have already implemented them in the OWL models, and could regenerate DTDL from that. I'm a little less certain about the changes to the meters -- it seems we are changing their properties to no longer represent the accumulated value of whatever they are measuring, and instead are adding properties relating to how they are rated/what they can measure. Is that a correct interpretation? Might there not be use also for properties which actually describe the accumulated value reading of the meter? It's not my home field, so I'd just like to double-check before proceeding on these.

Yes, your understanding is exactly correct. I realized that our meter models still had the "telemetry" properties of what it is measuring, but we have since introduced the Capability models which is where these values should be setup and trended just like every other asset that has associated telemetry.

The properties which I've left or updated are the actual rating or capacity of the meter based on its specifications.

Makes perfect sense. I’ll proceed on this tomorrow. Thanks for the clarification.

I hope the other updates I took the liberty of applying are acceptable.

Karl

hammar commented 2 years ago

Makes perfect sense. I’ll proceed on this tomorrow. Thanks for the clarification.

I just rebuilt the Meters from OWL also. Just waiting on o decision re. deprecated models and pipe diamater, and then I think we're done on this one :-)

rszcodronski commented 2 years ago

@hammar - can we try to get this one merged in this week?

I provided above my responses to both of your outstanding questions (pipe diameter and deprecated models), but let me know if there are any others. Thanks!

hammar commented 2 years ago

Sorry for the delay on this @rszcodronski -- and thanks for all these contributions and discussions!