Azure / opendigitaltwins-building

Open Digital Twins Definition Language (DTDL) RealEstateCore Ontology
MIT License
150 stars 42 forks source link

Why does ElectricityMeter not have the relationship 'measures'? #72

Open mwdhont opened 2 years ago

mwdhont commented 2 years ago

While WaterMeter, GasMeter do have this relationship?

hammar commented 2 years ago

Hi,

ElectricityMeters are supposed to measure ElectricalCircuits (see https://doc.realestatecore.io/3.3/full.html#Electricitymeter). However in the process of translating to DTDL there was an unresolved discussion on whether ElectricalCircuits were assets, collections, or something else -- so for the moment they are not in the models and the linkage isn't established.

@rszcodronski, @alinamstanciu, we probably need to revisit this discussion for the REC 3 models at some point soon. This is needed. Was there any particular reason why we didn't use the Willow design for this?

Also, note that In REC4, if we do proceed with Brick Schema integration as discussed, this entire structure will probably look quite different (see https://brickschema.org/ontology/Nightly/classes/Equipment).

Best,

Karl

mwdhont commented 2 years ago

Hi Karl,

Thanks for the reply. Since we are most interested to monitor the electricity consumption of assets, this choice would make sense to us. However, I see that the 'measures'-relationship for the other type of meters is not restricted to certain targets, so giving the same freedom for ElectricityMeters, would make the discussion obsolete I guess.

Michiel