search

Azure / opendigitaltwins-building

Open Digital Twins Definition Language (DTDL) RealEstateCore Ontology
MIT License
155 stars 44 forks source link

Update/Correct description of "REC Full" section in README.md #8

Closed nazar-kuzo closed 3 years ago

nazar-kuzo commented 3 years ago

I have noticed that "REC Full" section has mentioned about:

This full version was generated using OWL2DTDL converter which created FullBuildingRecModels.json to be uploaded into your Azure Digital Twins instance as described by upload models article.

But seems like this file was renamed to "FullBuildingModels.json" (Ontology/FullBuildingModels.json) If this readme section is supposed to point to this file, it would be great if somebody could update the name of the file and/or insert link to this file for easier navigation.

Thanks!

alinamstanciu commented 3 years ago

Hi @nazar-kuzo , we have change it from this approach to a different one and forgot to delete the comment. There is a current limitation in Azure Digital Twins today with the number of models uploaded in one API call, also a bug with the payload size, that for now I've decided to use model uploader to upload all models. Check out our model uploader in this repo.

I will address the upload models section ASAP. Thanks for your feedback

nazar-kuzo commented 3 years ago

Thanks, uploader works well