search

Azure / opendigitaltwins-dtdl

Digital Twins Definition Language
Creative Commons Attribution 4.0 International
473 stars 161 forks source link

[v3] Consider updating displayName size to be >= name #145

Closed rido-min closed 1 year ago

rido-min commented 1 year ago

In v3 the name limit has been increased from 64 to 512. I guess the displayName should be equal or greater than name

rido-min commented 1 year ago

@jrdouceur can we consider this for v3 ?

jrdouceur commented 1 year ago

I suppose we could run this by the DSC, too. I had thought this was a deliberate omission from the previous change proposal, since the stated motivation for increasing the limit on name does not seem to apply to displayName. Also, a very long displayName could have a negative effect on a generated UI, so there seems potentially more risk to this.

rido-min commented 1 year ago

AFAIK this was not a deliberated omission. I don't see any risk of increasing displayName size. Will be weird to have longer names than displayNames. I'm not aware of any generated UI tool, but if any, it can always shrink the string to whatever size fits in the UI.

jrdouceur commented 1 year ago

I have no objection to this change. Feel free to follow the same course of action as with the increase to name length limit. I suspect the DSC will close on it quickly.

rido-min commented 1 year ago

closed with #154