search

Azure / opendigitaltwins-dtdl

Digital Twins Definition Language
Creative Commons Attribution 4.0 International
470 stars 160 forks source link

Updating samples to be DTDLv2 based #54

Closed jspaith closed 4 years ago

jspaith commented 4 years ago

Update samples so they are based on DTDLv2.

Make a few other changes, such as removing asynchronous commands from sample (the diagnostics stuff). We're very, very likely removing support for this as an SDK / broader PnP concept so we should get out of sample sooner than later.

briancr-ms commented 4 years ago 
  "name": "state",

Is this the right example? How can a device report its state as offline if it's offline?

Refers to: samples/EnvironmentalSensor.interface.json:12 in 30af214. [](commit_id = 30af21468e4505193e5bbe9ab264e8ec9c3bff4f, deletion_comment = False)

briancr-ms commented 4 years ago 
},

If only three values are supported (1, 2, and 3), do we really need a long schema here? Should we use integer instead?

Refers to: samples/EnvironmentalSensor.interface.json:30 in 30af214. [](commit_id = 30af21468e4505193e5bbe9ab264e8ec9c3bff4f, deletion_comment = False)

briancr-ms commented 4 years ago 
  ],

In DTDL v2, semantic types are not prefixed with "SemanticType/". This should just be "Temperature".

Refers to: samples/EnvironmentalSensor.interface.json:35 in 30af214. [](commit_id = 30af21468e4505193e5bbe9ab264e8ec9c3bff4f, deletion_comment = False)

briancr-ms commented 4 years ago 
  ],

In DTDL v2, semantic types are not prefixed with "SemanticType/". If this is intended to be relative humidity, then the semantic type is "RelativeHumidity".

Refers to: samples/EnvironmentalSensor.interface.json:45 in 30af214. [](commit_id = 30af21468e4505193e5bbe9ab264e8ec9c3bff4f, deletion_comment = False)

briancr-ms commented 4 years ago 
  },

Should we be using the long schema in our examples, since not all devices will be able to implement it?

Refers to: samples/EnvironmentalSensor.interface.json:58 in 30af214. [](commit_id = 30af21468e4505193e5bbe9ab264e8ec9c3bff4f, deletion_comment = False)