search

Azure / opendigitaltwins-smartcities

DTDL based ontology for Smart Cities
MIT License
71 stars 28 forks source link

contactPoint Property implemented as string? Why not using the structure from Schema.org #30

Open JMayrbaeurl opened 3 years ago

JMayrbaeurl commented 3 years ago

Hi,

Several models contain the property 'contactPoint', that is declared with the schema 'string' in all DTDL models (e.g. OffstreetParking.json). But the ETSI specification defines ContactPoint from Schema.org for the contactPoint properties. Shouldn't we replace the string with a dedicated ContactPoint model in the crossdomain folder?

gdetant commented 3 years ago

That is a good point. We don't have the complete set of schema.org, but we can model what we need of course

JMayrbaeurl commented 3 years ago

BTW. Since we'll need Schema.org models quite often, I've created a dedicated repo for them. See e.g. ContactPoint.json. @miriambrus Do we have plans for a generic base ontology for all our domain specific ontologies?

JMayrbaeurl commented 3 years ago

As discussed with @miriambrus per e-mail, I've added ContactPoint from Schema.org with a PR #37