Speed up testing by priming Kind cluster's docker registry with all required images

[nitishm]

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] Slow tests since all images need to be pulled from the remote docker registries for the first test case.

Describe the solution you'd like A clear and concise description of what you want to happen. Prime the Kind docker registry by prepopulating it with bookinfo, ambassador and workflow executor images.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

[nitishm]

See https://github.com/kubernetes-sigs/kind/issues/2063#issuecomment-775734522

[mahalrs]

@nitishm @jonathan-innis This is what I'm thinking of doing in #340. Let me know if you have any suggestions.

Local Development Workflow

• STEP 1
  • make setup-dev-env: This will:
  • Clean any previous Orkestra kind cluster including local registry.
  • Create Orkestra kind cluster with local registry.
  • Prepopulate local registry with required images for testing.
• STEP 2
  • Loop
  • Make any code changes.
  • make dev or make debug: This will:
    • Delete any previous Orkestra installation. This will not delete kind cluster. Deleting and creating kind cluster takes time. So, we should not delete and create cluster every time there's a change. Instead we should only delete Orkestra installation and any resources created by make test such as bookinfo.
    • Install Orkestra using helm install...
    • Run main.go in debug mode in case of make debug
  • Run tests using make test
  • Repeat unless done.
• STEP 3
  • Final cleanup using make clean-all: This will delete the kind cluster with local registry. You should only use this if you wish to delete the kind cluster. For most of the time, you should use make dev or make debug which automatically deletes any previous Orkestra helm chart installation.
  • After running make clean-all you should run make setup-dev-env before using make dev or make debug.

[nitishm]

For clarity make dev would deploy Orkestra helm chart with values-ci.yaml i.e. start with orkestra controller disabled. This will allow the end-user to run their local changes either using the --debug flag or using a debugger.