search

Azure / orkestra

Orkestra is a cloud-native release orchestration and lifecycle management (LCM) platform for the fine-grained orchestration of inter-dependent helm charts and their dependencies
https://azure.github.io/orkestra
Other
104 stars 16 forks source link

Application namespaces should be created only by the controller since the ApplicationGroup owns each of the created resources #291

Open nitishm opened 3 years ago

nitishm commented 3 years ago

Currently, the namespace creation is duplicated in both the reconciler and the executor container. It would be better to have the reconciler create the namespace while ignoring 'Already Exists' errors.

Additionally, in keeping with helm client's --create-namespace option, the created namespace should also be labeled with 

labels:
  name: <namespace>
nitishm commented 3 years ago

/cc @jonathan-innis @mgl1969

nitishm commented 3 years ago

For reference, the two places where this happens currently are,

Orkestra: https://github.com/Azure/orkestra/blob/main/pkg/workflow/argo.go#L121-L133

Workflow Executor: https://github.com/Azure/orkestra-workflow-executor/blob/main/main.go#L116-L136