Azure / orkestra

Orkestra is a cloud-native release orchestration and lifecycle management (LCM) platform for the fine-grained orchestration of inter-dependent helm charts and their dependencies
https://azure.github.io/orkestra
Other
105 stars 16 forks source link

Speed up local testing by priming Kind cluster's docker registry with all required images #340

Closed mahalrs closed 1 year ago

mahalrs commented 3 years ago

Part of #225

Few changes to local dev workflow:

mahalrs commented 3 years ago

@nitishm Let's merge this, and I will keep an eye on kind PR.

jonathan-innis commented 3 years ago

Overall, looks good @mahalrs

nitishm commented 3 years ago

Why is the first most basic test in suite failing 😕😕 while everything else passes. Have you tried running it locally?

mahalrs commented 3 years ago

Why is the first most basic test in suite failing 😕😕 while everything else passes. Have you tried running it locally?

It's working locally.

nitishm commented 3 years ago

Try commenting out the first test and commit the changes to see if the rest pass or is it always the first one in the suite that fails. We can then narrow down on what's causing the issue

mahalrs commented 3 years ago

Try commenting out the first test and commit the changes to see if the rest pass or is it always the first one in the suite that fails. We can then narrow down on what's causing the issue

Looks like it's the first test in suite that fails. Let's merge PR #343 (I did some refactoring and all tests are passing in it). It's part of parallel tests but it gonna take some time until I fix issue with running tests in parallel. If you wish we can merge it now, and then I will make another PR for parallel tests.

nitishm commented 3 years ago

Looks like it's the first test in suite that fails. Let's merge PR #343 (I did some refactoring and all tests are passing in it). It's part of parallel tests but it will take sometime until I fix issue with running tests in parallel. If you wish we can merge it now, and then I will make another PR for parallel tests.

343 is a WIP. Are you suggesting we are ready to merge it in? I have left a comment in that PR since it doesn't seem to show significant improvement compared to the original. If you think the changes made there will fix this maybe cherry-pick the changes into this one?

mahalrs commented 3 years ago

Looks like it's the first test in suite that fails. Let's merge PR #343 (I did some refactoring and all tests are passing in it). It's part of parallel tests but it will take sometime until I fix issue with running tests in parallel. If you wish we can merge it now, and then I will make another PR for parallel tests.

343 is a WIP. Are you suggesting we are ready to merge it in? I have left a comment in that PR since it doesn't seem to show significant improvement compared to the original. If you think the changes made there will fix this maybe cherry-pick the changes into this one?

Yes, that PR is ready to merge in if we run tests sequentially (I did some refactoring to make it easy to track issue with parallel tests). It's just like the code in main branch but refactored. I haven't pushed any other changes in it yet.

EDIT: We will change that PR to a code refactor PR since it doesn't have any changes related to parallel tests.

mahalrs commented 3 years ago

@nitishm Let me change that PR to a code refactor PR.