Closed mahalrs closed 1 year ago
@nitishm Let's merge this, and I will keep an eye on kind PR.
Overall, looks good @mahalrs
Why is the first most basic test in suite failing 😕😕 while everything else passes. Have you tried running it locally?
Why is the first most basic test in suite failing 😕😕 while everything else passes. Have you tried running it locally?
It's working locally.
Try commenting out the first test and commit the changes to see if the rest pass or is it always the first one in the suite that fails. We can then narrow down on what's causing the issue
Try commenting out the first test and commit the changes to see if the rest pass or is it always the first one in the suite that fails. We can then narrow down on what's causing the issue
Looks like it's the first test in suite that fails. Let's merge PR #343 (I did some refactoring and all tests are passing in it). It's part of parallel tests but it gonna take some time until I fix issue with running tests in parallel. If you wish we can merge it now, and then I will make another PR for parallel tests.
Looks like it's the first test in suite that fails. Let's merge PR #343 (I did some refactoring and all tests are passing in it). It's part of parallel tests but it will take sometime until I fix issue with running tests in parallel. If you wish we can merge it now, and then I will make another PR for parallel tests.
Looks like it's the first test in suite that fails. Let's merge PR #343 (I did some refactoring and all tests are passing in it). It's part of parallel tests but it will take sometime until I fix issue with running tests in parallel. If you wish we can merge it now, and then I will make another PR for parallel tests.
343 is a WIP. Are you suggesting we are ready to merge it in? I have left a comment in that PR since it doesn't seem to show significant improvement compared to the original. If you think the changes made there will fix this maybe cherry-pick the changes into this one?
Yes, that PR is ready to merge in if we run tests sequentially (I did some refactoring to make it easy to track issue with parallel tests). It's just like the code in main branch but refactored. I haven't pushed any other changes in it yet.
EDIT: We will change that PR to a code refactor PR since it doesn't have any changes related to parallel tests.
@nitishm Let me change that PR to a code refactor PR.
Part of #225
Few changes to local dev workflow:
make setup
: Create kind cluster with local registry and prepopulate the local registry with required images. Also, load required images to kind node. You need to use this only once or after you runmake clean
or restart docker/kind.make dev
: Deploy the Orkestra helm chart (values-ci.yaml) with Orkestra controller disabled.make debug
: Deploy the Orkestra helm chart (values-ci.yaml) with Orkestra controller enabled (in debug mode).make clean-chart
: Cleanup any previous Orkestra helm chart installation. When you make any code changes, runmake clean-chart && make dev
.make clean
: Cleanup any Orkestra installation and the kind cluster with registry. After running this target, you must runmake setup
before runningmake dev
ormake debug
.