search

Azure / orkestra

Orkestra is a cloud-native release orchestration and lifecycle management (LCM) platform for the fine-grained orchestration of inter-dependent helm charts and their dependencies
https://azure.github.io/orkestra
Other
105 stars 16 forks source link

Fix invalid pointer and slice bug in Graph.bft() #350

Closed mahalrs closed 3 years ago

mahalrs commented 3 years ago

Closes #349

codecov-commenter commented 3 years ago

Codecov Report

Merging #350 (9f466bb) into main (d2c214a) will increase coverage by 0.08%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #350      +/-   ##
==========================================
+ Coverage   39.08%   39.16%   +0.08%     
==========================================
  Files          14       14              
  Lines         811      817       +6     
==========================================
+ Hits          317      320       +3     
- Misses        483      487       +4     
+ Partials       11       10       -1
Impacted Files Coverage Δ
pkg/workflow/graph.go 10.95% <0.00%> (-0.99%) :arrow_down:
controllers/appgroup_controller.go 77.46% <0.00%> (+4.22%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d2c214a...9f466bb. Read the comment docs.

jonathan-innis commented 3 years ago

@mahalrs Approving, but for my understanding, can you explain the specific scenario that has raised this bug?

mahalrs commented 3 years ago

@mahalrs Approving, but for my understanding, can you explain the specific scenario that has raised this bug?

I'm writing unit tests for workflow/graph and one of the test case results in a runtime error if I pass in v1alpha13.NodeStatus{} with only ID and Type field and other fields default to their zero values.