Closed jonathan-innis closed 3 years ago
Overall LGTM - address the unit tests CI failures and we should be good to merge this in.
Merging #371 (d8d4feb) into main (3989de1) will increase coverage by
2.34%
. The diff coverage is74.50%
.
@@ Coverage Diff @@
## main #371 +/- ##
==========================================
+ Coverage 29.70% 32.04% +2.34%
==========================================
Files 13 13
Lines 707 596 -111
==========================================
- Hits 210 191 -19
+ Misses 487 398 -89
+ Partials 10 7 -3
Impacted Files | Coverage Δ | |
---|---|---|
pkg/workflow/workflow.go | 0.00% <ø> (ø) |
|
pkg/workflow/workflow_forward.go | 0.00% <0.00%> (ø) |
|
pkg/workflow/workflow_reverse.go | 0.00% <0.00%> (ø) |
|
pkg/workflow/workflow_rollback.go | 0.00% <0.00%> (ø) |
|
pkg/workflow/templates.go | 81.25% <68.57%> (-2.20%) |
:arrow_down: |
pkg/workflow/graph.go | 92.98% <92.85%> (+82.02%) |
:arrow_up: |
controllers/appgroup_controller.go | 73.23% <0.00%> (-4.23%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 3989de1...d8d4feb. Read the comment docs.