Closed nitishm closed 3 years ago
@jonathan-innis we can merge this in rather than have you fork from my branch. Adding these API changes should be benign (I think). WDYT? That way you can just work off of main
@jonathan-innis we can merge this in rather than have you fork from my branch. Adding these API changes should be benign (I think). WDYT? That way you can just work off of main
Yes, in general, I agree that merging these changes is benign
Merging #380 (3a07d7e) into main (b7b480a) will not change coverage. The diff coverage is
n/a
.:exclamation: Current head 3a07d7e differs from pull request most recent head 00a8cb3. Consider uploading reports for the commit 00a8cb3 to get more accurate results
@@ Coverage Diff @@
## main #380 +/- ##
=======================================
Coverage 67.14% 67.14%
=======================================
Files 8 8
Lines 350 350
=======================================
Hits 235 235
Misses 106 106
Partials 9 9
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update b7b480a...00a8cb3. Read the comment docs.
Addresses #379
Signed-off-by: Nitish Malhotra nitish.malhotra@gmail.com