search

Azure / orkestra

Orkestra is a cloud-native release orchestration and lifecycle management (LCM) platform for the fine-grained orchestration of inter-dependent helm charts and their dependencies
https://azure.github.io/orkestra
Other
104 stars 16 forks source link

Set keptn prometheus service and RBAC namespace to Orkestra #398

Closed nitishm closed 3 years ago

nitishm commented 3 years ago

Closes #397

Signed-off-by: Nitish Malhotra nitish.malhotra@gmail.com

nitishm commented 3 years ago

@scotty-c Please try this out and let me know if you encounter any issues

codecov-commenter commented 3 years ago

Codecov Report

Merging #398 (164af9d) into main (a413430) will decrease coverage by 0.58%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #398      +/-   ##
==========================================
- Coverage   70.40%   69.82%   -0.59%     
==========================================
  Files           9        9              
  Lines         517      517              
==========================================
- Hits          364      361       -3     
- Misses        132      134       +2     
- Partials       21       22       +1
Impacted Files Coverage Δ
controllers/appgroup_controller.go 77.19% <0.00%> (-5.27%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a413430...164af9d. Read the comment docs.

scotty-c commented 3 years ago

@nitishm one change i would make is to change this command kubectl create -f bookinfo-keptn-cm.yaml -n orkestra to kubectl create -f examples/keptn/bookinfo.yaml so the user can stay in the root directory to run the demo

scotty-c commented 3 years ago

LGTM