passphrase is not stored in keyvault when calling install.sh twice - Githubissues

Azure / osdu-infrastructure

OSDU Azure Infrastructure as Code

Apache License 2.0

42 stars 39 forks source link

passphrase is not stored in keyvault when calling install.sh twice #36

Closed fbosquet-azpn closed 4 years ago

fbosquet-azpn commented 4 years ago

All Submissions:

[YES] Have you added an explanation of what your changes do and why you'd like us to include them?
[YES] I have updated the documentation accordingly.
[NA] I have added tests to cover my changes.
[NA] All new and existing tests passed.

Current Behavior or Linked Issues

This is a proposal for fixing issue #21 (interruption of the install.sh script when running it twice)

Does this introduce a breaking change?

[NO]

Other information

The proposal is to store the PASSPHRASE variable in a file so that we can retreived it later.

danielscholl commented 4 years ago

Thanks for the PR. I've included your change in PR #40