Azure / packer-azure

Packer for Azure
MIT License
115 stars 50 forks source link

New parameter os_image_name #188

Closed romachalm closed 8 years ago

romachalm commented 8 years ago

The proposed code adds a parameter os_image_name to be used instead of os_image_label. It allows to precise the name of the source image either :

For instance :

"os_image_name": "Ubuntu-14_04_3-LTS-amd64-server-20150805-en-us-30GB"
"os_image_name": "b39f27a8b8c64d52b05eac6a62ebad85__Ubuntu-14_04_3-LTS-amd64-server-20150805-en-us-30GB"

It should solve the issue #108 as the user can more easily find the name of the OS he is looking for, and implements the #131 .

msftclas commented 8 years ago

Hi @rchalumeau, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

msftclas commented 8 years ago

@rchalumeau, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, MSBOT;

paulmey commented 8 years ago

LGTM, Travis has some unrelated issue with the Azure SDK. If you can squash the changes into a single commit, I'll merge it

romachalm commented 8 years ago

Done @paulmey, the four commits are now one

paulmey commented 8 years ago

The SDK issue is supposed to be fixed somewhere later this morning, so I'll merge this now and see if anything needs fixing... :+1: